• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tomasnorre / crawler / 43818818671
79%

Build:
DEFAULT BRANCH: main
Ran 16 Nov 2026 06:50AM UTC
Jobs 1
Files 58
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Nov 2026 06:44AM UTC coverage: 68.855% (-0.07%) from 68.921%
43818818671

push

github

web-flow
!!! [TASK] Keep the state of compiling URLs in a CrawlRun (#1340)

* !!! [TASK] Keep the state of compiling URLs in a CrawlRun

QueueEntryWriter and PageTreeUrlCollector are shared services, but kept
the options and results of a run in public properties: the set id, the
handled URLs, the download URLs, the URL list and the collected queue
entries. Callers had to set and reset them, and state could leak from
one run into the next.

AOE\Crawler\Queue\CrawlRun now holds the options of one run and collects
its results. It is created per run and handed over as parameter, so both
services are stateless.

* QueueEntryWriter::compileUrlList() and addUrl() take a CrawlRun
* PageTreeUrlCollector::collect() and getQueueRowsForPage() take a CrawlRun
* QueueEntryWriter::addCallback() takes the set id as optional parameter
* BackendModuleStartCrawlingController no longer needs the QueueEntryWriter

The new unit tests of compileUrlList() covered code that had no unit tests
before, and the mutants escaping there lowered the covered code MSI.

* CrawlRun builds the key of a handled URL and calculates the scheduled
  time of the next URL, both tested exactly
* compileUrlList() checks the processing instruction filter once instead
  of for every URL, it does not change within a configuration
* Tests for base URL and force_ssl, URLs that cannot be built, user groups
  and processing instruction filters of handled URLs, numeric
  configuration keys and several parsed parameters

63 of 76 new or added lines in 6 files covered. (82.89%)

1269 of 1843 relevant lines covered (68.86%)

5.19 hits per line

Uncovered Changes

Lines Coverage ∆ File
10
0.0
0.0% Classes/Controller/Backend/BackendModuleStartCrawlingController.php
2
86.44
-0.66% Classes/Command/BuildQueueCommand.php
1
82.02
-3.69% Classes/Service/PageTreeUrlCollector.php
Jobs
ID Job ID Ran Files Coverage
1 43818818671.1 16 Nov 2026 06:45AM UTC 58
68.86
GitHub Action Run
Source Files on build 43818818671
  • Tree
  • List 58
  • Changed 5
  • Source Changed 0
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • bda12f03 on github
  • Prev Build on main (#43810889582)
  • Next Build on main (#43828331753)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc