mindersec / minder / 43731288480

68%

push

github

Reject ambiguous repo lookups by name (#7058)

* Reject ambiguous repo lookups by name

When no provider is specified, GetRepositoryByName and
DeleteRepositoryByName search across all providers in the project and
silently use the first match. If the same owner/name is registered with
more than one provider (e.g. GitHub and GitLab), this can return or
delete the wrong repository.

Keep the convenient behaviour when the name is unique, but return an
InvalidArgument error asking the user to specify a provider when more
than one repository matches.

Fixes #3220

* Use UserVisibleError for ambiguous repo names

Return util.UserVisibleError directly from the repository service
rather than a sentinel error that each handler has to translate. This
removes the special cases from the RPC handlers, per review.

DeleteRepositoryByName wraps unexpected errors as Internal, which would
have hidden the InvalidArgument from the user, so pass user-visible
errors through unchanged there. Also reword the message, since the check
can fire even when a provider was specified.

16 of 16 new or added lines in 2 files covered. (100.0%)

24343 of 35992 relevant lines covered (67.63%)

59.9 hits per line