optimizely / javascript-sdk / 43481805754

77%

Build Type

push

github

Committed by web-flow

Commit Message

[FSSDK-13432] Don't treat the first invalid datafile from datafileManager as fatal (#1188)

## Summary
- `ProjectConfigManagerImpl` no longer fails to start on the first invalid datafile from the `datafileManager`. Startup now fails only after `MAX_INVALID_DATAFILE_EMIT` (3) invalid datafiles arrive before a valid one. A valid datafile within that limit starts the manager as usual.
- An invalid datafile with no `datafileManager` is still a fatal init error, as before.
- `jsonSchemaValidator` and `datafileManager` are now `private`.

A single bad response, such as a truncated or corrupted payload, used to stop the SDK from starting even though the next poll would have returned a valid datafile.

Coverage Stats

1564 of 3060 branches covered (51.11%)

Branch coverage included in aggregate %.

1 of 5 new or added lines in 1 file covered. (20.0%)

1 existing line in 1 file now uncovered.

9002 of 10575 relevant lines covered (85.13%)

261.04 hits per line