• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 43440192169
79%

Build:
DEFAULT BRANCH: development
Ran 13 Nov 2026 04:06PM UTC
Jobs 1
Files 803
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Nov 2026 02:10PM UTC coverage: 78.875% (+0.2%) from 78.66%
43440192169

push

github

web-flow
fix(node): distinguish DoubleSpend from AlreadyMined in HTTP submit_transaction (#8298)

## Description

1.
**`applications/minotari_node/src/http/handler/json_rpc/submit_transaction.rs`**:
- Distinguish `TxSubmissionRejectionReason::DoubleSpend` from
`TxSubmissionRejectionReason::AlreadyMined` (matching P2P
`submit_transaction`) by checking whether the rejected transaction's
first kernel signature is mined on chain, falling back to `AlreadyMined`
if the lookup errors.
2. **`applications/minotari_node/src/http/handler/mod.rs`**:
- Map `query_service::Error::SignatureConversion` to
`StatusCode::BAD_REQUEST` instead of `StatusCode::INTERNAL_SERVER_ERROR`
on `/transaction_query`.

*(Note: Rebased onto `development` and dropped the
`sync_utxos_by_block.rs` hunk after #8332 landed `cache_height()`.)*

## How Has This Been Tested?

- `cargo +nightly fmt --all -- --check`
- `cargo lints clippy --all-targets -p minotari_node`
- `cargo test -p minotari_node --lib http::handler::`

Co-authored-by: SW van Heerden <swvheerden@gmail.com>

153425 of 194517 relevant lines covered (78.87%)

508875.77 hits per line

Coverage Regressions

Lines Coverage ∆ File
100
93.98
2.42% base_layer/core/src/mempool/mempool_storage.rs
71
98.53
0.1% base_layer/core/src/mempool/unconfirmed_pool/unconfirmed_pool.rs
64
67.11
0.3% base_layer/core/src/chain_storage/blockchain_database.rs
57
92.98
-0.01% base_layer/core/src/proof_of_work/monero_rx/helpers.rs
47
17.21
-0.43% base_layer/core/src/base_node/proto/wallet_rpc.rs
47
72.65
0.0% base_layer/core/src/base_node/rpc/service.rs
45
41.83
12.69% base_layer/wallet/src/transaction_service/protocols/transaction_broadcast_protocol.rs
43
83.41
4.85% base_layer/core/src/base_node/rpc/query_service.rs
42
85.94
0.0% base_layer/core/src/base_node/comms_interface/inbound_handlers.rs
32
95.89
0.13% base_layer/transaction_components/src/transaction_builder/builder.rs
15
75.72
-0.21% comms/core/src/connectivity/manager.rs
12
29.79
-0.65% base_layer/core/src/mempool/mod.rs
7
96.01
0.0% base_layer/core/src/mempool/mempool.rs
7
89.08
-2.39% comms/core/src/connectivity/connection_pool.rs
6
96.8
1.19% base_layer/transaction_components/src/transaction_components/burn_output_proof.rs
5
93.66
-0.06% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
5
91.08
-0.4% comms/core/src/multiplexing/yamux.rs
5
83.26
-0.72% comms/core/src/protocol/rpc/client/mod.rs
4
96.05
1.29% base_layer/core/src/mempool/service/inbound_handlers.rs
4
89.13
-4.35% base_layer/core/src/test_helpers/block_spec.rs
3
55.98
-1.63% base_layer/core/src/validation/block_body/block_body_partial_validator.rs
3
72.66
-0.14% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
2
21.05
21.05% base_layer/transaction_components/src/rpc/models/tx_submission_response.rs
1
91.97
-0.08% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
1
34.62
-1.38% base_layer/core/src/mempool/proto/tx_storage_response.rs
1
90.0
17.27% base_layer/core/src/proof_of_work/monero_rx/error.rs
1
77.59
0.06% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
Jobs
ID Job ID Ran Files Coverage
1 43440192169.1 13 Nov 2026 04:06PM UTC 803
78.87
GitHub Action Run
Source Files on build 43440192169
  • Tree
  • List 803
  • Changed 41
  • Source Changed 18
  • Coverage Changed 41
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43440192169
  • ffaafede on github
  • Prev Build on development (#43408212912)
  • Next Build on development (#43822446542)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc