43454924680
84%

Ran 13 Nov 2026 03:47PM UTC

Jobs 2

Files 169

Run time 1min

Badge

Embed ▾

Committed 13 Nov 2026 03:40PM UTC coverage: 83.512% (+0.04%) from 83.471%

Build # 43454924680

Build Type

push

github

Committed by

web-flow

Commit Message

feat(source): skip nodes being removed or excluded from load balancers (#6860)

* feat(source): skip nodes being removed or excluded from load balancers

--exclude-unschedulable now also skips Nodes that are being removed, in the
node and service sources: Nodes with deletionTimestamp set, and Nodes tainted
ToBeDeletedByClusterAutoscaler or karpenter.sh/disrupted.

NodePort targets skip Nodes labelled
node.kubernetes.io/exclude-from-external-load-balancers, with the same rule
as the cloud-provider service controller: any value that doesn't parse as
false excludes the Node. The node source doesn't use the label.

- externalTrafficPolicy=Local drops excluded Nodes, cordoned ones included,
  before the readiness tiers are compared, so the best tier among the
  remaining Nodes wins instead of the records ending up empty.
- The service source re-syncs on Node events when it has a Node informer.
  Updates that leave addresses, labels, taints, spec.unschedulable and the
  deletion state unchanged are ignored.

Docs: Service source NodePort section, node source and the
--exclude-unschedulable help text.

* shorten code comments

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

---------

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

Coverage Stats

16608 of 19887 relevant lines covered (83.51%)

1464.0 hits per line

Coverage Regressions

Lines	Coverage	∆	File
6	93.1	0.06%	node.go
4	93.51	0.18%	service.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	run-macos-latest - 43454924680.1	13 Nov 2026 03:47PM UTC	169	83.51	GitHub Action Run
2	run-ubuntu-latest - 43454924680.2	13 Nov 2026 03:48PM UTC	169	83.5	GitHub Action Run

kubernetes-sigs / external-dns / 43454924680
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 43454924680

kubernetes-sigs / external-dns / 43454924680 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 43454924680

kubernetes-sigs / external-dns / 43454924680
84%

README BADGES
x