tgrk / ex_oura / 818665511766da315c89bcff8a3a13fc110caab0-PR-101

73%

master: 72%

Build Type

Pull #101

github

Committed by tgrk

Commit Message

fix: make Req retry callback match Req's (request, response) contract

should_retry?/2 pattern-matched {:error, response} tuples, but Req calls
the :retry function with the request and the response or exception, so
it always returned false and requests were never retried. retry_delay/1
also assumed a 1-based attempt while Req passes a 0-based retry count.

Add a test that runs a 503-then-200 response through Req, and drop the
duplicate tuple-based retry test and the order-dependent
function_exported? check.

Pull Request Pull Request #101: fix: restore Req retries; docs: correct and deduplicate README

Coverage Stats

2 of 4 new or added lines in 2 files covered. (50.0%)

31 existing lines in 2 files now uncovered.

668 of 923 relevant lines covered (72.37%)

33083.68 hits per line