openconfig / featureprofiles / 43370150429

7%

push

github

rundata: report git commit/dirty for reftable repos and pre-reservation failures (#6248)

* rundata: report git commit/dirty for reftable repos and pre-reservation failures

go-git v5 cannot open repositories that use the reftable ref storage
(extensions.refstorage=reftable), which is what git creates when
feature.experimental is set (and will be the default in git 3.0). gitInfo
silently returned, so no git.commit/git.clean properties were reported and
the Ondatra -jsonl ledger had no gitCommit/gitDirty.

- Fall back to the git CLI when go-git fails to open an existing repo.
- Publish git properties in fptest.RunTests before ondatra.RunTests, so
  binding and reservation failures are also attributed to a commit.

* rundata: add tests for the git CLI fallback and GitProperties

Read the origin from config (not remote get-url) so the CLI fallback
reports the same raw URL as go-git, unaffected by url.insteadOf.

* rundata: bound git CLI calls with a timeout and avoid index.lock

Address review feedback: run git via exec.CommandContext with a 10s
timeout, pass --no-optional-locks to git status, and use
strconv.FormatBool for git.clean.

37 of 40 new or added lines in 2 files covered. (92.5%)

2377 of 32958 relevant lines covered (7.21%)

0.08 hits per line