uber / h3 / 43347340663

100%

push

github

Exit with non-zero status when CLI arguments fail to parse (#1300)

* Exit with non-zero status when CLI arguments fail to parse

PARSE_SUBCOMMAND returned E_SUCCESS whenever parseArgs returned non-zero,
which covers both --help and real parse failures (unknown argument,
missing required argument, missing or unparseable value). The usage text
was printed to stderr but the process still exited 0, so scripts could
not detect the failure. Return E_FAILED unless help was requested.

* Fail CLI parsing errors even when --help is also given

parseArgs sets helpArg.found as soon as it sees --help, then can still
fail on a later argument (e.g. `cellToLatLng --help --bogus`). The
previous check used helpArg.found, so those cases exited 0. Dispatch on
the parseArgs return code instead: PARSE_ARGS_HELP is the only non-zero
code that means help was printed without an error. The PARSE_ARGS_*
codes move from args.c to args.h so callers can use them.

1941 of 1951 branches covered (99.49%)

Branch coverage included in aggregate %.

3428 of 3431 relevant lines covered (99.91%)

36826962.1 hits per line