solidjs / solid / 43310392045

79%

main: 90%

push

github

fix(store): drop a nested write through a loading chained store, warn in dev (#4808) (#4810)

* fix(signals): a nested write through a loading chained store writes its seed (#4808)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* fix(signals): restore the write override in a finally (#4808 review)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* fix(signals): refuse a nested write through a loading chained store with a named dev diagnostic (#4808)

Copying the loading store's seed as the draft's base (the previous commits)
showed the seed for every key the setter did not write, for good: the copy
detaches the child, as the same write after the first answer does (A25).
The write stays refused with the read's NotReadyError, as on next, and dev
reports STORE_WRITE_THROUGH_LOADING first. No production bytes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* chore(solid): regenerate diagnostics.json for STORE_WRITE_THROUGH_LOADING (#4808)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* fix(store): drop a nested write through a loading chained store instead of throwing (#4808)

Maintainer, 2026-11-12: throwing is not an option. The nested write is
dropped, as a write to a loading store is replaced by its first answer
(A25), and the outer keeps following the inner store; the setter's other
writes land. Dev warns with STORE_WRITE_THROUGH_LOADING (now severity
warn). Docs, skill, catalog and changeset updated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* refactor(store): fold the #4808 drop into ensurePB (a throwaway backing, no call-site checks)

C... (continued)

818 of 1112 branches covered (73.56%)

Branch coverage included in aggregate %.

1143 of 1372 relevant lines covered (83.31%)

30.11 hits per line