• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 43307049429
88%

Build:
DEFAULT BRANCH: master
Ran 12 Nov 2026 09:27PM UTC
Jobs 1
Files 526
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Nov 2026 09:07PM UTC coverage: 88.119% (-0.02%) from 88.134%
43307049429

push

github

Gerold103
applier: fix crash on instance name set via self

When `box.cfg{instance_name = ...}` is called on a read-only replica
whose replication config includes its own URI and the real master is
not reachable, `replicaset_find_join_master` can return the instance
itself as the "join master". The applier-to-self then reaches
`APPLIER_OFF` with an empty diagnostics area because the
`ER_CONNECTION_TO_SELF` branch in `applier_f` skipped
`applier_set_last_error`. This violated the invariant assumed by
`applier_wait_for_state`, causing a NULL pointer dereference in
`error_ref`.

This patch makes 2 fixes:
1. In `applier_f`, always save the error into `applier->diag` when
   one exists in the fiber diag, regardless of the `log_error` flag.
   This change is sufficient to prevent the crash, but the user
   gets `ER_CONNECTION_TO_SELF` instead of proper error.
2. In `box_register_on_master`, reject self as a join master,
   mirroring the existing guard in bootstrap. This fixes the
   error to be consistent with bootstrap.

Closes #13081

NO_DOC=bugfix

72875 of 121730 branches covered (59.87%)

4 of 4 new or added lines in 2 files covered. (100.0%)

52 existing lines in 14 files now uncovered.

109505 of 124270 relevant lines covered (88.12%)

1442277.21 hits per line

Coverage Regressions

Lines Coverage ∆ File
16
90.72
-0.42% src/box/box.cc
14
92.36
-1.98% src/box/memtx_space.c
5
92.58
-0.22% src/box/vinyl.c
3
92.45
-0.3% src/box/vy_scheduler.c
2
96.48
-0.08% src/box/iproto.cc
2
89.72
-0.13% src/box/xrow.c
2
93.43
-0.36% src/box/xrow_update_field.c
2
72.17
-1.74% src/lib/core/opt_def.c
1
95.21
-0.53% src/box/vy_range.c
1
96.47
-0.21% src/box/vy_read_iterator.c
1
94.41
-0.08% src/lib/core/fiber.c
1
97.09
-0.05% src/lib/salad/bps_tree.h
1
92.07
-0.11% src/lib/swim/swim.c
1
22.64
-0.02% src/lib/uri/uri_parser.c
Jobs
ID Job ID Ran Files Coverage
1 43307049429.1 12 Nov 2026 09:27PM UTC 526
88.12
GitHub Action Run
Source Files on build 43307049429
  • Tree
  • List 526
  • Changed 28
  • Source Changed 0
  • Coverage Changed 28
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • 465ca674 on github
  • Prev Build on master (#43077485915)
  • Next Build on master (#43307249568)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc