solidjs / solid / 43268857718

79%

main: 90%

push

github

fix(signals): fall through borrowed keys to the lending guess carrier (#4793)

* fix(signals): fall through borrowed keys to the lending guess carrier

A guess's frame is the draft composed on the view, so it holds another
action's guessed values at keys this guess did not itself write. An
array guess is recorded as an arrangement guess, and the arrangement
read claims every index, so the surviving guess's frame kept serving
the expired value at the other action's index after that action ended.

Record, on each guess carrier, the keys its frame only carries over
from another live guess's carrier (`borrowed`). The arrangement read
in `guessFor` no longer claims a borrowed key: the read falls through
to the lending carrier while it lives, and to the truth once the
lender dissolves. Keys the guess wrote itself still match through
`wk`/`del` first, and single-guess arrangement reads are unchanged.

Fixes #4784

Signed-off-by: xh123637 <3324733895@qq.com>

* fix(signals): do not borrow rows a keyed guess carried over verbatim

The borrowed-key fall-through (#4784) recorded every key another live
guess's carrier claimed, including indices whose row the setter carried
over unchanged in a keyed list. Falling through to the lender's carrier
for such a key re-linked the reader to the lender, and the notification
carrying the new arrangement to the DOM was lost: in the #4724
whole-array setter case the map state was correct but the DOM kept
showing the closed row.

A row carried over verbatim is not borrowed (`carriedVerbatim`): the
frame holds the view's row object (the `echoes` normalization), and the
row target — not the frame copy — decides the row's contents, so the
arrangement read serves this frame's copy and the reader stays linked
to this carrier. Primitives still borrow: the lender may rewrite the
value, and the frame's copy would go stale.

Adds the two variants from review: the reverse end order, and the
lending action rewriting its own index after t... (continued)

818 of 1112 branches covered (73.56%)

Branch coverage included in aggregate %.

1143 of 1372 relevant lines covered (83.31%)

30.23 hits per line