microlinkhq / unavatar / 43238674270

98%

push

github

fix(reachable-url): don't cache refused pings, rate limits by Retry-After (#719)

* fix(reachable-url): cache refused pings for 5 minutes

A ping that gets 403, 408, 429 or a 5xx was cached for a day like any
other result, so one refusal from an image host turned a working avatar
into a fallback for 24 hours. Those now expire after 5 minutes; 2xx and
404 keep the 1 day TTL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(reachable-url): never cache refused pings

Instead of a 5 minute TTL, a ping answered with 403, 408, 429 or a 5xx
is not stored at all: the memoized function throws it, @keyvhq/memoize
skips the write, and the caller unwraps it. The next request pings the
host again.

Calls reachable-url and @keyvhq/memoize directly; @microlink/ping-url
only wrapped those two and had no way to skip a write. Cache keys and
stored values are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(reachable-url): cache rate limited pings for their Retry-After

Not caching a 429 sends a fresh ping on every request to a host that
asked us to slow down. A 429 is now cached for its Retry-After (seconds
or HTTP date), 1 minute when absent, clamped to 1s-10m so a zero or past
value never means 'no expiry' and a huge one never pins a fallback.
403, 408 and 5xx stay uncached.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(reachable-url): don't treat a blank Retry-After as zero

A whitespace-only Retry-After parsed as zero seconds, so it was cached for the one-second floor instead of the one-minute default, and a duplicate header joined with a comma was ignored. Blank values now use that default, and the first delay-seconds of a joined header is kept.

* fix(reachable-url): don't parse a joined Retry-After as a date

Date.parse accepts strings such as ",60", so a duplicate delay-seconds header was cached for the one-second floor. A value is an HTTP-date only when it contains letters, which still covers the three... (continued)

1383 of 1446 branches covered (95.64%)

Branch coverage included in aggregate %.

71 of 71 new or added lines in 1 file covered. (100.0%)

4515 of 4549 relevant lines covered (99.25%)

8.81 hits per line