supabase / realtime / 43191846854

93%

Build Type

push

github

Committed by web-flow

Commit Message

feat(policy_eval): Reload snapshot after mismatch to rule out staleness (#2554)

Right now we don't really know whether a mismatch is a "real" mismatch
or whether we've been running against a stale snapshot (while the real
check always runs against the most current policy).

This makes that check and so gives us the information if it's real or
staleness.

While we observe relatively few mismatches right now in production,
it also has a security mechanism built in that prevents it from always
just reloading: A reload is only done once per TTL cycle.

To support this we have a new `Entry` struct that wraps the snapshot,
it records the reason why it was loaded and if the reason is `mismatch`
it only refreshes once the TTL is up - not for mismatch reloading.

We also make sure that for a given entry only one refresh can be in
flight at the same time.

Coverage Stats

33 of 35 new or added lines in 2 files covered. (94.29%)

1 existing line in 1 file now uncovered.

4830 of 5180 relevant lines covered (93.24%)

4724.85 hits per line