liran-funaro / sphinx-markdown-builder / 43183779725

100%

push

github

Remove dead code and useless lint suppressions (#132)

## Summary

Small cleanups from #121. None of them change the output.

- `builder.py`: remove `self.sec_numbers`. It was assigned in
`__init__`, `init()` and `write_doc()`, but nothing read it.
- `contexts.py`: remove the dead `sys.version_info >= (3, 8)` branch
(`requires-python = ">=3.11"`). `Target = typing.Literal["body",
"head"]` stays, and the unused `import sys` goes.
- Remove the two suppressions that `pylint --enable=useless-suppression`
reports as useless: `too-many-arguments` on `WrappedContext.__init__`
and `too-many-return-statements` on `_find_predefined_method`.
- `pyproject.toml`: remove `[tool.poetry.plugins]` /
`[tool.poetry.plugins."sphinx.builders"]`. They repeat
`[project.entry-points."sphinx.builders"]`, and Poetry never reads them
because the build backend is setuptools.

## Before / after

The Markdown output is identical: `make test-diff` passes with no change
to `tests/expected/`.

## Commands

- `pylint sphinx_markdown_builder --disable C0116,C0115
--enable=useless-suppression`: before, 2 `I0021` messages; after, none
(10.00/10)
- `make lint`: passed
- `make test`: passed (diff clean, 15 passed, coverage 100%)
- Reinstalled with `pip install -e .`:
`entry_points(group="sphinx.builders", name="markdown")` still resolves
to `sphinx_markdown_builder`

Closes #121

2 of 2 new or added lines in 2 files covered. (100.0%)

773 of 773 relevant lines covered (100.0%)

4.0 hits per line