• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubernetes-sigs / inference-perf / 43102138070
87%

Build:
DEFAULT BRANCH: main
Ran 11 Nov 2026 09:34PM UTC
Jobs 1
Files 141
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

11 Nov 2026 09:20PM UTC coverage: 86.408% (-0.007%) from 86.415%
43102138070

push

github

web-flow
fix: accept license headers the check wrongly rejected (#1063)

Follow-up to the license-check problem raised in #914, which @Bslabe123
asked for as a separate PR.

**Old behavior:** `scripts/check_license.py` built its expected header
with `datetime.date.today().year` and required the file to start with
exactly that text. Three consequences:

- Every file carrying an older copyright year failed as soon as the
calendar turned over. A file should keep the year it was written in, so
the check was asking correct files to be wrong. 15 files carry a 2025
header today.
- A shebang has to be the first line of an executable script, which puts
the header on line 2. Every such file failed, `scripts/check_license.py`
included, so the check did not pass itself.
- Eight files indent the license URL the way the Apache boilerplate does
(`# http://...`). That indentation counted as a mismatch.

Together these failed 41 of the repo's 426 `.py` files, which is why the
`check-license` pre-push hook has been getting skipped with
`--no-verify`.

**New behavior:** the template is matched as a pattern rather than an
exact prefix:

- any four-digit year
- an optional shebang ahead of the header, with or without a blank line
after it
- either indentation of the license URL, since both are the Apache
boilerplate and neither is worth rewriting files over
- empty files are skipped, since they carry no code to license

The check keeps its teeth. Altered license wording, a missing header,
and a header sitting below a module docstring all still fail.

This takes the repo-wide count from 41 failing files to 17. Those 17
have no Apache header at all, rather than one the check misreads, so
they are a content gap rather than a checker bug. I left them out of
this PR to keep it to the one behavior; happy to add the headers here or
in a follow-up, whichever you prefer.

Changes:
- `scripts/check_license.py`: build the pattern from the template once,
tolerate the shapes above, skip empty ... (continued)

13745 of 15907 relevant lines covered (86.41%)

0.86 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
79.17
-1.04% inference_perf/datagen/base.py
Jobs
ID Job ID Ran Files Coverage
1 43102138070.1 11 Nov 2026 09:34PM UTC 141
86.41
GitHub Action Run
Source Files on build 43102138070
  • Tree
  • List 141
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43102138070
  • 2119af9e on github
  • Prev Build on main (#43069413293)
  • Next Build on main (#43153644407)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc