brawer / osmdiffs / 43016205893

94%

push

github

fix(edits): Compare opening hours as weekly schedules (#926)

`opening_hours` values are now compared by the weekly schedule they
describe, so `24/7` and `Mo-Su 00:00-24:00` agree, both in
`match.evidence.agreeing` and in the edit suggester. This also fixes
`agreeing`, which split the value at `;` and so counted one rule in
common as agreement.

The edit suggester no longer replaces OSM opening hours that say more
than AllThePlaces can, such as public holidays, dates or comments
(#321). It compares `start_date` and `end_date` at the precision of
the vaguer value, leaves vague OSM dates such as `~1980` alone,
suggests only ATP values that are dates, and drops the time from
timestamps such as `2015-12-10T00:00:00.000Z`.

On the 2026-11-02 planet file, this drops about 94,000 of the 265,000
opening hours edits: 63,000 with the same schedule, 31,000 where OSM
has richer syntax.

Part of #924.


Claude-Session: https://claude.ai/code/session_01Ttfb2LhDRExioXkdHbxLno

Co-authored-by: Claude <noreply@anthropic.com>

285 of 287 new or added lines in 3 files covered. (99.3%)

17066 of 18200 relevant lines covered (93.77%)

3622.68 hits per line