solidjs / solid / 42978210095

79%

main: 90%

push

github

fix: ref callbacks run like a render effect's callback (#4761) (#4768)

* fix: ref callbacks run like a render effect's callback (#4761)

A ref callback ran under runWithOwner(null), so its reads were outside
reads and saw the screen before the pass that builds the element had
committed. A non-keyed Show/Match branch hidden by an optimistic write
threw a stale read from its ref on restore and halted.

runRefCallback (internal) runs the callback untracked in the creating
pass's context, as a render effect's first callback run does. In dev the
ref is a strict-read, effect-callback scope: creating a primitive or
onCleanup there throws; writes, refresh, actions and onFlush are allowed.
Prod pays only untrack in ref().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* ref(): runRefCallback in dev only; prod calls untrack directly

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

---------

Co-authored-by: Claude <noreply@anthropic.com>

818 of 1112 branches covered (73.56%)

Branch coverage included in aggregate %.

1143 of 1372 relevant lines covered (83.31%)

30.18 hits per line