GrottoCenter / grottocenter-api / 42965417849

91%

develop: 91%

Build Type

Pull #2003

github

Committed by tristan0x

Commit Message

fix(geoloc): reject non-numeric bounding box params with a 400 (#2000)

- checkAndGetCoordinatesParams now checks that each coordinate is a finite
  decimal or exponent number before the range check; a comparison between a
  non-numeric string and a number is always false, so such values reached
  Postgres and failed with 22P02, sent back as a 500
- reject empty strings, hexadecimal, NaN, Infinity, overflowing exponents
  and repeated parameters, naming every offending parameter
- covers all eight geoloc endpoints, GET and HEAD alike
- document non-numeric coordinates in the 400 of GET /geoloc/entrances

Pull Request Pull Request #2003: fix(geoloc): reject non-numeric bounding box params with a 400 (#2000)

Coverage Stats

7660 of 8773 branches covered (87.31%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

13870 of 14929 relevant lines covered (92.91%)

221323.29 hits per line