GrottoCenter / grottocenter-api / 42965311559

91%

develop: 91%

Pull #2002

github

fix(search): handle a union multi-search error body instead of a 500 (#2001)

- A union multi-search does not throw when one of its searches fails:
  Typesense answers HTTP 200 with { code, error } and no hits, which
  made toSearchResult crash on source.hits.map
- multiCollectionsSearch now logs the raw response and throws an error
  carrying the Typesense code as httpStatus, so handleTypesenseError
  answers a 4xx with a 400, as for a single-collection search
- A body of unknown shape stays a 500, but the log now shows it
- Stub multiSearch with the real union shape ({ hits }) in the tests
- Document the 400 and 500 cases of POST /search

7662 of 8771 branches covered (87.36%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

13870 of 14926 relevant lines covered (92.93%)

216604.31 hits per line