simplifi / elixir-thrift / 6c9898902cf875925b9fadfb5c82e4d60836e8b5-PR-4

89%

master: 91%

Build Type

Pull #4

github

Committed by nathanmonteleone

Commit Message

Fix compilation warnings and AST generation bug for Elixir 1.18/1.19

- Fix map default values generating invalid AST in struct_generator: Utils.quote_value
  for maps was returning an actual %{} Elixir map rather than proper AST ({:%{}, [], pairs}).
  Elixir 1.18 introduced stricter unquote validation that rejects non-AST values.

- Fix struct update warnings in Elixir 1.19 by adding explicit %StructName{} = var
  pattern matches to function heads in ast.ex (all merge/2 clauses), generator.ex
  (generate_schema/1, generate_to_string!/1 lambda), and file_group.ex
  (set_current_module/2).

- Remove --force from mix compile --warnings-as-errors in CI: --force was causing
  the connection dependency to be recompiled under warnings-as-errors, surfacing
  its charlist deprecation warnings as errors. deps.compile handles dep compilation
  separately; without --force, mix compile only recompiles changed project files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #4: Require elixir >= 1.18 and OTP >= 27. Unpin all deps.

Coverage Stats

3 of 4 new or added lines in 2 files covered. (75.0%)

36 existing lines in 9 files now uncovered.

907 of 1022 relevant lines covered (88.75%)

365.09 hits per line