supabase / storage / 42910811871

88%

Build Type

push

github

Committed by web-flow

Commit Message

fix: stamp webhooks applyTime at commit time and ensure ordering (#1691)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

- When an object is deleted, the `ObjectRemoved` and `ObjectPromoted`
webhooks get their `applyTime` stamped when the webhook is sent, not
when the database change actually committed.
- If backend content cleanup after a delete is slow, a newer unrelated
write to the same object can end up with an earlier `applyTime` than the
delayed delete or promotion webhook.
- When a delete promotes an older version at the same key, the removed
and promoted webhooks for that key have no guaranteed ordering between
them. Depending on delivery order, the cache can end up showing the
object as deleted instead of showing the promoted version.
- For a same-path move (like restoring an older version onto itself),
the "removed" and "created" events for that key could tie. The cache
could end up showing the object as removed even though the restore
worked.


## What is the new behavior?

- `applyTime` now reflects the moment the database transaction
committed, not when the webhook was actually sent.
- A newer unrelated write can no longer be mistaken for older just
because a prior delete's backend cleanup took a while.
- When a delete promotes an older version at the same key, the promoted
webhook always carries a later `applyTime` than its paired removed
webhook.
- For a same-path move, the "created" event always wins over the
"removed" event for that key.

## Additional context

The CDN cache uses `applyTime` to enforce a last-write-wins cache and
keeps whichever webhook has the higher applyTime. So a slow delete or
promotion can incorrectly overwrite a newer write in the cache

Coverage Stats

8488 of 10192 branches covered (83.28%)

Branch coverage included in aggregate %.

40 of 42 new or added lines in 3 files covered. (95.24%)

3 existing lines in 1 file now uncovered.

14516 of 16063 relevant lines covered (90.37%)

1354.78 hits per line