supabase / storage / 42895744060

88%

push

github

fix(iceberg): purge a tenant's Iceberg resources on delete with purge=true (#1686)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

When a tenant is deleted we don't clean up its Iceberg resources. The
catalog, namespace, and table rows stay in the MT database, the shard
slots are never freed, and the tables and namespaces stay in the S3
Tables shard buckets. In staging this filled up the shard buckets
(10,000 namespace limit per bucket), which caused `too_many_namespaces`
errors and failing Iceberg acceptance tests.

## What is the new behavior?

We add a `purge` query param that can be used when the tenant is
"officially" deleted. Currently there are times when the `DELETE
/admin/tenants/:tenantId` endpoint is called but it's just temporarily,
so we don't want to remove anything.

When `purge=true` is set, before deleting the tenant row we clean up the
tenant's Iceberg resources the same way deleting an analytics bucket
does (see `BucketDeleted`).

## Additional context

8486 of 10192 branches covered (83.26%)

Branch coverage included in aggregate %.

8 of 9 new or added lines in 2 files covered. (88.89%)

14511 of 16060 relevant lines covered (90.35%)

1353.73 hits per line