solidjs / solid / 42865567235

79%

main: 89%

push

github

fix(web): fail renders on pre-flush serialization errors (#4713)

* fix(web): fail renders on pre-flush serialization errors

* fix(web): send an unserializable error record as a plain Error

A contained error's record (an <Errored> record, or the rejection a
deferStream source writes) no longer fails the render before the first
flush when the default serializer cannot encode it. The record is written
again as a plain Error with its message, so the fallback stays and
onCompleteAll fires. The replacement is cached per error, so every record
of the same error carries it and the error hook hears serialize once.
Values that fail to serialize still fail the render.

* test(web): pin the plain record after the first flush

* test(web): bound the artifact child process and keep its stderr

The spec builds its prod and dev results in a child Node during
collection. A handle left open there would hang the whole suite, and
an import failure lost its diagnostic. Give the child a timeout and
pipe its stderr into the thrown error.

* fix(web): fail uncontained rejections and contain streamed ones

A deferStream rejection was sent as a plain Error whether or not an
<Errored> caught it, so one handed to the writer with no boundary
completed the render. <Errored> now tells the renderer what it contained
(context.contained), and a rejection the default serializer cannot encode
is kept only when its reason is one of those errors. A piped render meets
the rejection ahead of its boundary, so the failure waits for the shell,
where the root holes were pulled again.

A streamed rejection inside an <Errored> is contained too. The keyed
serializer passes the failing key to onError, the renderer maps it to the
reason that key's promise rejected with, and the promise is rejected on
the client with the plain Error its boundary's record carries, marked the
way seroval marks a rejection.

* test(web): replay the contained streamed rejection on the client

The server half records t... (continued)

818 of 1112 branches covered (73.56%)

Branch coverage included in aggregate %.

1143 of 1372 relevant lines covered (83.31%)

30.21 hits per line