GrottoCenter / grottocenter-api / 42856018644

91%

develop: 91%

Pull #1999

github

fix(avatar): delete the avatar of a deleted or merged caver or organization (#1730)

- Add AvatarService.destroyOwner: lock the record, read its avatar path,
  destroy it and record the path for deletion in one transaction, then
  delete the image
- Use it for the caver delete and merge, and for the permanent delete and
  merge of an organization; a merge target keeps its own avatar, and a
  soft-deleted organization keeps its avatar
- An avatar update running at the same time either lands before the lock,
  and its image is the one deleted, or finds no record and deletes its own
  upload
- Test caver and organization deletion and merge, storage failure, a
  destroy that keeps the row and a destroy that fails

7655 of 8765 branches covered (87.34%)

Branch coverage included in aggregate %.

184 of 221 new or added lines in 14 files covered. (83.26%)

13864 of 14920 relevant lines covered (92.92%)

227936.15 hits per line