• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 42831924886
79%

Build:
DEFAULT BRANCH: development
Ran 10 Nov 2026 04:03PM UTC
Jobs 1
Files 803
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

10 Nov 2026 02:13PM UTC coverage: 78.591% (+0.07%) from 78.518%
42831924886

push

github

web-flow
fix(console_wallet): fix completed_txs removal, PartialRead skip order, and non-ledger build (#8283)

## Description
This PR fixes several bugs in `minotari_console_wallet`:

1. **Remove missing transaction from `completed_txs` instead of
`pending_txs`
(`applications/minotari_console_wallet/src/ui/state/app_state.rs`)**:
- In `AppStateInner::refresh_single_transaction_state`, when
`get_any_transaction(tx_id)` returned `None`, the second lookup found
the index `i` in `self.data.completed_txs`
(`self.data.completed_txs.iter().position(|i| i.tx_id == tx_id)`) and
then called `self.data.pending_txs.remove(index)` instead of
`self.data.completed_txs.remove(index)`.
- This left the deleted transaction in `completed_txs` and panicked with
an index out-of-bounds error whenever `index >=
self.data.pending_txs.len()`.

2. **Fix `PartialRead` iterator order and parent directory checks
(`applications/minotari_console_wallet/src/automation/utils.rs`)**:
- `json_from_file_single_object` called
`.lines().take(val.lines_to_read).skip(val.lines_to_skip)` instead of
`.skip(val.lines_to_skip).take(val.lines_to_read)`, which took
`lines_to_read` lines from the beginning of the file before skipping.
- `append_json_line_to_file` and `append_to_json_file` called
`fs::create_dir_all(file.as_ref().parent().unwrap())`, which panics or
fails with `NotFound` when given a bare filename (`parent() ==
Some("")`). Guard with `if let Some(parent) = file.as_ref().parent() &&
!parent.as_os_str().is_empty()`.

3. **Avoid panicking on closed `watch::Sender` in
`send_burn_transaction_task`
(`applications/minotari_console_wallet/src/ui/state/tasks.rs`)**:
- `send_burn_transaction_task` called `result_tx.send(...).unwrap()`,
which panics if the UI receiver is dropped before the burn transaction
finishes. Ignore closed-receiver errors consistently with
`send_one_sided_to_stealth_address_transaction`.

4. **Fix non-`ledger` feature compilation and recovery rate calculation
(`applications/mino... (continued)

149905 of 190740 relevant lines covered (78.59%)

1198135.17 hits per line

Coverage Regressions

Lines Coverage ∆ File
1137
65.99
1.47% base_layer/core/src/chain_storage/blockchain_database.rs
69
78.75
-1.38% base_layer/core/src/base_node/rpc/query_service.rs
47
66.49
-0.63% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
29
78.71
0.0% comms/core/src/connectivity/manager.rs
13
86.93
-1.56% base_layer/core/src/test_helpers/blockchain.rs
7
88.85
-1.22% comms/core/src/connection_manager/dialer.rs
7
92.12
-2.9% comms/core/src/protocol/rpc/status.rs
6
0.0
0.0% base_layer/transaction_components/src/rpc/models/sync_utxos_by_block.rs
5
73.08
-0.14% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
4
94.96
2.23% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
4
89.25
-4.3% base_layer/core/src/test_helpers/block_spec.rs
3
67.92
0.0% base_layer/core/src/base_node/sync/rpc/service.rs
3
36.63
-2.97% base_layer/core/src/chain_storage/error.rs
3
77.55
0.18% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
3
85.8
-0.62% comms/core/src/protocol/messaging/inbound.rs
2
87.45
-0.2% base_layer/core/src/proof_of_work/cuckaroo_pow.rs
1
86.99
-0.23% base_layer/core/src/mempool/service/service.rs
1
78.57
-1.43% comms/core/src/test_utils/mocks/connection_manager.rs
1
91.28
0.22% comms/dht/src/actor.rs
Jobs
ID Job ID Ran Files Coverage
1 42831924886.1 10 Nov 2026 04:03PM UTC 803
78.59
GitHub Action Run
Source Files on build 42831924886
  • Tree
  • List 803
  • Changed 28
  • Source Changed 3
  • Coverage Changed 28
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42831924886
  • f6f28024 on github
  • Prev Build on development (#42789650516)
  • Next Build on development (#42958766653)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc