sds / overcommit / 42762484609
100%
master: 91%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 18
Files 223
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.456%. Remained the same
42762484609

push

github

web-flow 
Document the case-sensitive KtLint hook name (#927)

The configuration in #787 uses `Ktlint`, while the built-in hook is
named `KtLint`. With `required_executable: ktlint`, the misspelled name
becomes an ad hoc hook. It receives Git's original hook arguments, so a
pre-commit invocation runs Ktlint with no filenames and scans unmodified
files too.

Document the exact built-in name, give a minimal working configuration,
and explain why the alternative spelling behaves differently. Strengthen
the existing KtLint success example to require passing the applicable
filenames to the executable.

Fixes #787 through a configuration correction; no runtime change is
necessary.

Local reproduction with Ktlint 1.8.0 downloaded into `/tmp` and a
disposable Git repository:

- Commit an invalid `Bad.kt`, then stage only a valid `Good.kt` and
Overcommit configuration.
- With the report's `Ktlint` spelling, a real commit fails and reports
the unchanged `Bad.kt`.
- Change only the hook name to `KtLint`: the real commit succeeds and
does not report `Bad.kt`.

Validation: existing KtLint specs pass with the stronger argument
assertion; RuboCop passes. Full CI is required before merging.

Final verification: [run
42762226697](https://github.com/sds/overcommit/actions/runs/42762226697)
passed all 38 checks, including Linux/Windows Ruby 3.3, 3.4, and 4.0,
lint, CI, and all coverage statuses. All 20 completed jobs report zero
annotations.

3346 of 3619 relevant lines covered (92.46%)

3914.09 hits per line

Jobs
ID Job ID Ran Files Coverage
1 ruby3.4-windows-shard4of5 - 42762484609.1 446
73.52
GitHub Action Run
2 ruby3.3-windows-shard1of5 - 42762484609.2 446
71.86
GitHub Action Run
3 ruby4.0-windows-shard2of5 - 42762484609.3 446
72.22
GitHub Action Run
4 ruby3.4-windows-shard5of5 - 42762484609.4 446
73.49
GitHub Action Run
5 ruby3.3-windows-shard2of5 - 42762484609.5 446
72.36
GitHub Action Run
6 ruby3.3-windows-shard3of5 - 42762484609.6 446
77.73
GitHub Action Run
7 ruby4.0-ubuntu-shard1of1 - 42762484609.7 446
92.43
GitHub Action Run
8 ruby4.0-windows-shard5of5 - 42762484609.8 446
73.55
GitHub Action Run
9 ruby3.4-windows-shard1of5 - 42762484609.9 446
71.84
GitHub Action Run
10 ruby4.0-windows-shard4of5 - 42762484609.10 446
73.52
GitHub Action Run
11 ruby3.4-windows-shard2of5 - 42762484609.11 446
72.31
GitHub Action Run
12 ruby3.4-windows-shard3of5 - 42762484609.12 446
77.69
GitHub Action Run
13 ruby3.3-windows-shard5of5 - 42762484609.13 446
73.55
GitHub Action Run
14 ruby3.3-ubuntu-shard1of1 - 42762484609.14 446
92.42
GitHub Action Run
15 ruby3.4-ubuntu-shard1of1 - 42762484609.15 446
92.43
GitHub Action Run
16 ruby4.0-windows-shard3of5 - 42762484609.16 446
77.69
GitHub Action Run
17 ruby3.3-windows-shard4of5 - 42762484609.17 446
73.55
GitHub Action Run
18 ruby4.0-windows-shard1of5 - 42762484609.18 446
71.84
GitHub Action Run
Source Files on build 42762484609