sds / overcommit / 42761164328

100%

master: 91%

push

github

Preserve standard input bytes when forwarding hooks (#925)

Overcommit forwards ad hoc hook input using `puts`, which adds a newline
to an empty stream or to an unterminated record. For a post-rewrite
consumer such as git-branchless, an empty stream becomes a blank record
and fails with `Invalid rewrite line`.

Read hook stdin and write the supplied subprocess input in binary mode.
This preserves empty input, record terminators, and arbitrary bytes on
Windows as well as Unix, while still closing stdin so the child sees
EOF.

Fixes #869.

Reproduced locally through an installed post-rewrite CustomScript using
a small parser with git-branchless's empty-stream/blank-record behavior.
Before the fix, empty input fails with `Invalid rewrite line`, and
unterminated input gains a newline. The fixture verifies arguments and
exact bytes for empty, unterminated, LF, multiline, and CRLF input.
Subprocess tests also cover binary data; existing expectations that
assumed an added newline now expect the actual supplied input.

Validation: full local RSpec suite (1,738 examples); RuboCop on all
changed Ruby files. Full Linux/Windows CI runs on the PR.

Also verified against git-branchless 0.11.1 downloaded into `/tmp` and
initialized only in a disposable repository: forwarding an empty stream
exits 0; forwarding the injected blank line exits 1 with `Invalid
rewrite line`. No system installation or existing repository
configuration was changed.

The first Windows CI run exposed stdin CRLF conversion before
forwarding; HookContext now reads the original stream in binary mode as
well. The CRLF integration case remains identical on every platform.

5 of 5 new or added lines in 2 files covered. (100.0%)

3346 of 3619 relevant lines covered (92.46%)

3914.09 hits per line