sds / overcommit / 42759854195

100%

master: 91%

push

github

Fail when Git cannot enumerate tracked files (#923)

`overcommit --run` currently reports success when Git cannot read the
index, because `GitRepo.all_files` treats failed `git ls-files` commands
as valid empty output. Check both enumeration results and raise an
Overcommit error containing Git's exit status and output before running
hooks against an incomplete file list.

Fixes #909.

Reproduced locally with a corrupt index in a disposable repository: the
CLI regression test exited 0 before this change. Regression coverage
also checks the second enumeration command failing independently, a
valid empty index, untracked and deleted files, and a normal
trailing-whitespace failure. Existing deleted-file and submodule
behavior is preserved.

Validation: full local RSpec suite (1,718 examples); RuboCop on changed
Ruby files. GitHub Actions additionally exercises Linux and Windows on
Ruby 3.3, 3.4, and 4.0.

The first CI run passed all test jobs and lint, with aggregate coverage
increasing to 92.450%. Partial-shard Coveralls comparisons reported
decreases because added examples changed shard assignments. Additional
boundary controls preserve the existing assignment offsets; the final
run must pass those comparisons as well.

6 of 6 new or added lines in 1 file covered. (100.0%)

3343 of 3616 relevant lines covered (92.45%)

3814.99 hits per line