google / alioth / 42730887926

40%

Build Type

push

github

Committed by Lencerf

Commit Message

fix(virtio/fs): reply errors to vhost-user backend requests

VuFs panics at a backend request other than SHMEM_MAP and SHMEM_UNMAP,
and stops the device when a SHMEM request fails, e.g. with a range
outside the DAX window. It also replies to every request, even if the
backend did not set VHOST_USER_NEED_REPLY.

Return an error at an unsupported request instead of panicking: its
payload is unknown, so the backend channel cannot go on. When a SHMEM
request fails, log the error and reply a non-zero value, as the
vhost-user spec requires, and reply only if the backend asks for it.

Fixes: 359ab26fb216 ("feat(fs): support virtio-fs DAX mapping")
Signed-off-by: Changyuan Lyu <changyuanl@google.com>

Coverage Stats

894 of 1704 branches covered (52.46%)

Branch coverage included in aggregate %.

37 of 48 new or added lines in 1 file covered. (77.08%)

90 existing lines in 3 files now uncovered.

6356 of 16261 relevant lines covered (39.09%)

903.46 hits per line