solidjs / solid / 42725211664

79%

main: 89%

push

github

fix(compiler): escape string literals in SSR branches and returns (#4712)

* fix(compiler): escape string literals in SSR branches and returns

- Escape string and template literals in a ternary branch, after `&&`,
  and in a function child's return at compile time in the server build.
- `_$ssr` and `_$ssrAttribute` write these values unescaped, so the server
  rendered markup where the client inserted text.
- A function value in an attribute keeps its source, because
  `_$ssrAttribute` stringifies it.
- Apply the same change to the Babel plugin to keep both compilers' output
  equal.

Fixes #4710

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(compiler): keep attribute function literals raw and escape nested returns

- A function value in an attribute keeps the literals in its ternary and
  `&&` branches as written. `ssrAttribute` stringifies the function's
  source and escapes it, so an escape at compile time escaped them twice.
- Escape every `return` of a function child or call, including one inside
  `if`, `switch`, `try`, a loop or a block. Nested functions stay as is.
- Replace the `escapeLiterals` flag with three modes (top, escape, keep) in
  both compilers, so the attribute exception carries through branches.
- Add fixtures for both cases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Ryan Carniato <ryansolid@gmail.com>

818 of 1112 branches covered (73.56%)

Branch coverage included in aggregate %.

1143 of 1372 relevant lines covered (83.31%)

30.05 hits per line