astronomer / astro-cli / 42704841049

62%

main: 45%

push

github

Drop de as an alias of delete; the 1.x spelling fails naming delete (#2467)

* Stop de from meaning delete; make the 1.x de spelling fail naming delete

de is astro deployment's alias, and 1.x also gave it to every delete, so
astro de de <id> deleted a Deployment. Every delete that answered to de now
answers to rm instead (Astro, APC and context). The 1.x spelling reaches a
hidden stub built by cliout.RemovedAlias on top of cliout.RemovedCommand: a
usage error (exit 2) that names the delete command and never runs it.

The 1.x command inventory lists the dropped alias paths so the inventory
test runs each stub, and TestDeleteAnswersOnlyToRmOrDel keeps delete and
remove to rm or del. On an APC context the stubs no longer load the
platform first.

Co-Authored-By: Claude <noreply@anthropic.com>

* Guard against a command sharing a word with an ancestor; fix the stub's help and error together

TestNoCommandAnswersToAWordAnAncestorAnswersTo fails when a command
answers to a word its parent or another ancestor also answers to, which is
how astro de de <id> came to delete. Removed-command stubs are exempt.
cliout.RemovedAlias now works out the stub's Short and its error message
from the same aliases, read once when the stub is built.

Co-Authored-By: Claude <noreply@anthropic.com>

* Give every delete and remove the alias rm; test that a removed alias never runs its command

- Every delete and remove command answers to rm and to no other alias:
  link remove, af runs delete, the token organization-token and
  workspace-token removes, organization team user remove, and APC's
  deployment user and team remove gain it. TestDeleteAndRemoveAnswerToRm
  replaces TestDeleteAnswersOnlyToRmOrDel and drops del, which nothing used.
- TestRemovedAliasStubsNeverRunTheirCommand runs every de stub on the real
  Astro, root and APC trees with its command's runs and pre-runs replaced
  by a recorder, and checks that the command never runs, the exit is 2 and
  the error names ... (continued)

103 of 104 new or added lines in 16 files covered. (99.04%)

43608 of 70848 relevant lines covered (61.55%)

367.62 hits per line