uber / h3 / 42681295527

100%

push

github

Include <math.h> in constants.h before the M_PI fallbacks (#1259)

constants.h defines M_PI/M_PI_2 fallbacks but does not include <math.h>. In a
translation unit that reaches constants.h before <math.h>, the fallback is
defined first with fewer digits than the platform's definition. When compiled
with Clang modules (as SwiftPM/Xcode build C targets), Clang compares the two
visible macro definitions by their token sequences, not their values, so it
reports -Wambiguous-macro for every M_PI/M_PI_2 use even though both spellings
convert to the same double.

Include <math.h> first so the platform's definition is visible before the
fallbacks, which then apply only where the platform provides none (e.g. MSVC
without _USE_MATH_DEFINES).

Fixes #1258

1937 of 1947 branches covered (99.49%)

Branch coverage included in aggregate %.

3424 of 3427 relevant lines covered (99.91%)

36863633.51 hits per line