PyCalendar / icalendar / 42677816164

98%

push

github

Compare `vCalAddress` by email address, ignoring case and `mailto:` (#1901)

* Compare vCalAddress by email address (issue #1896)

* Add tests for vCalAddress email equality (issue #1896)

* Add towncrier fragment for #1896

* Add author attribution and AI disclosure to news fragment

Addresses @angatha's requested changes on #1901.

AI use: Muse Spark 1.3 (muse-spark) by Meta drafted this change under my direction; I reviewed and validated the output and take responsibility for it.

* Coerce plain str to vCalAddress in __eq__ per #1901 review

Per @niccokunzmann's feedback: a plain str is converted via vCalAddress() before comparing, so `my_email in event.attendees` works; construction failure (e.g. newline) returns NotImplemented.

AI use: Muse Spark 1.3 (muse-spark) by Meta drafted this change under my direction; I reviewed and validated the output and take responsibility for it.

* Update tests for str coercion, add params test, ruff format

Reworks str-comparison tests for the new coercion behavior, adds test_equality_ignores_parameters suggested by @DhyeyBuch, and applies ruff format.

AI use: Muse Spark 1.3 (muse-spark) by Meta drafted this change under my direction; I reviewed and validated the output and take responsibility for it.

* fix(prop): add __ne__ to vCalAddress so != negates __eq__

vCalAddress extends str but only overrode __eq__. Without __ne__,
!= fell back to str.__ne__ (plain string comparison) and could
disagree with __eq__: case-insensitively equal addresses were both
== and !=. This also left the ValueError and fallback branches of
__eq__ uncovered. Add __ne__ delegating to __eq__ (propagating
NotImplemented) plus tests for ==/!= consistency and comparison
against non-str types.

* fix(prop): add __ne__ to vCalAddress so != negates __eq__

vCalAddress extends str but only overrode __eq__. Without __ne__,
!= fell back to str.__ne__ (plain string comparison) and could
disagree with __eq__: case-insensitively equal addresses we... (continued)

2096 of 2240 branches covered (93.57%)

Branch coverage included in aggregate %.

89 of 89 new or added lines in 2 files covered. (100.0%)

18930 of 19201 relevant lines covered (98.59%)

6.9 hits per line