supabase / supabase / 42655425768

87%

push

github

fix(studio): show OAuth app client secret in a blocking modal (#53167)

## Problem

After creating a confidential OAuth app or regenerating its client
secret, the credentials appeared in a small dismissible banner above the
apps table. The secret can't be retrieved again, so a missed banner
meant regenerating the secret and breaking existing integrations.

## Change

- Replace `NewOAuthAppBanner` with `NewOAuthAppModal`, following the
pattern of the S3 access key `CreateCredentialModal`.
- The modal shows the client ID and client secret with copy buttons and
states the secret won't be shown again.
- It can only be closed with Done. Outside clicks, Escape and the close
button are blocked.
- Public apps (no client secret) and plain edits behave as before: no
modal.
- Create and both regenerate entry points (row menu and sheet) feed the
same modal, so no data-layer changes.

Step 1:
<img width="420" height="251" alt="Image"
src="https://github.com/user-attachments/assets/74430837-90fd-49e9-9441-234abc97588a"
/>

Step 2:
<img width="420" height="375" alt="Image"
src="https://github.com/user-attachments/assets/92ab3786-8bd1-46cf-a4b4-b2643f288e65"
/>

## Testing

- Added `NewOAuthAppModal.test.tsx`: credentials and warning render, no
modal for public or missing apps, only Done dismisses.
- Manual: Authentication → OAuth Apps → create a confidential app, and
regenerate from the row menu and the sheet.

Closes #53116
Linear: FE-4976

2100 of 2473 branches covered (84.92%)

Branch coverage included in aggregate %.

2886 of 3245 relevant lines covered (88.94%)

201.0 hits per line