supabase / supabase / 42647357110

87%

push

github

fix(studio): handle architecture-prefixed Postgres versions in version helpers (#53162)

## Problem

`getDatabaseMajorVersion` and `getSemanticVersion` in
`apps/studio/lib/helpers.ts` returned `NaN` for Postgres versions with
an architecture prefix, e.g. `supabase-postgres-arm64-17.9.0.019`
(expected 17 / 1790019). `parseAppVersionKey` already handled `arm64-`
and `x86_64-`, but the two helpers did not.

Fixes FE-4974
Closes #53109

## Solution

- `formatSemver` now strips any leading architecture token
(`^[a-z][a-z0-9_]*-`) rather than a hardcoded list. A version segment
always starts with a digit, so this covers `arm`, `arm64`, `x86_64`,
`aarch64`, `amd64` and future values.
- `APP_VERSION_KEY_RE` in `useSelectedProject.utils.ts` uses the same
rule, so the two parsers stay consistent.
- Because the rule is generic, strings like
`supabase-postgres-custom-123` would otherwise parse as a number.
`formatSemver` now rejects anything that doesn't look like `\d+.\d+`
after stripping, and both helpers return `0` for it (matching their
existing empty-string behavior). Callers only compare the result
numerically, so `0` behaves like the previous `NaN`.

Tests cover each prefix on both helpers and on `parseAppVersionKey`, a
release suffix (`-vault-rc1`), and non-version strings.

Not changed: `getSemanticVersion` concatenates segments without padding
(`17.10.0.001` becomes 171001, which compares below `17.9.0.019`). That
predates this change and its callers pin to a single major line.

2099 of 2473 branches covered (84.88%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

2885 of 3245 relevant lines covered (88.91%)

200.97 hits per line