penguinolog / urwid / 42627379187

94%

Build Type

push

github

Committed by web-flow

Commit Message

Name the widget and its sizing in sizing-mode errors (#1612)

* Name the widget and its sizing in sizing-mode errors

A widget given a size of a sizing mode it does not support failed with a bare
"too many values to unpack" or "has no attribute 'rows'" deep inside urwid.
It now raises WidgetSizingError (fixes #247):

- The message names the widget, the size, the modes it supports and how to wrap it.
- Exception notes list the widgets that passed the size down, innermost first.
- WidgetMeta checks render, rows, pack, keypress and mouse_event of every Widget subclass, custom ones included.
- Raised errors also subclass the ValueError, IndexError or AttributeError they replace, with name/obj kept.
- An error from a supported size, a widget's own WidgetError, or a failing sizing() passes through unchanged.
- The error holds no reference cycle and pickles without the widget.

* Restore WidgetSizingError.name after unpickling on PyPy

PyPy's default BaseException.__setstate__ puts "name" into the instance dict
instead of setting AttributeError.name, so a pickled sizing error lost it.

- __setstate__ restores each state item with setattr().
- The pickled state no longer carries the id of the outermost widget, which
  means nothing in another process.

Coverage Stats

6868 of 7526 branches covered (91.26%)

Branch coverage included in aggregate %.

88 of 97 new or added lines in 1 file covered. (90.72%)

3 existing lines in 1 file now uncovered.

17676 of 18710 relevant lines covered (94.47%)

14.98 hits per line