stacklok / toolhive / 42586214531

73%

Build Type

push

github

Committed by web-flow

Commit Message

Clarify authserver ownership and shutdown (#7071)

Embedders need an explicit ownership boundary when constructing an auth server. Document caller-owned storage on failure, possible writes before failure, and the runner's different cleanup contract. Update examples to release resources on both success and failure.

Return a genuinely nil Server on construction errors instead of wrapping a nil pointer in an interface. Guard shutdown with sync.Once so concurrent and repeated Close calls return the same joined error without repeating cleanup or retrying failures.

Add regression coverage for partial construction after delegate registration and concurrent shutdown. Shared-storage ownership and request draining remain the embedder's responsibility.

Co-authored-by: Mecatl <noreply@mecatl.dev>

Coverage Stats

19 of 26 new or added lines in 2 files covered. (73.08%)

53 existing lines in 4 files now uncovered.

93791 of 128943 relevant lines covered (72.74%)

850.75 hits per line