ukorvl / lightweight-charts-react-components / 42566898088

100%

push

github

fix: multiple price scales in a pane

* fix: build workflow can write pull-requests

* fix: apply PriceScale options in its own pane and support overlay scale ids

PriceScale resolved the price scale without a pane index, so options were
applied to the first pane (#58), and a PriceScale nested in a series ran before
the series created its custom overlay scale, which threw "Trying to apply price
scale options with incorrect ID" in development builds (#402).

Pass the parent pane index to chart.priceScale() and wait for the parent
series before initializing. Cover it with unit tests, a real-chart test, a
README snippet, and an e2e check of the Panes sample overlay volume scale.

Closes #58
Closes #402

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: keep push lib test token read-only

Split the lib test job so only pull request runs get pull-requests: write for
the coverage report comment. Push and manual runs use a read-only token, which
is also the token passed to the Coveralls upload. The PR job keeps the
"Build and test lib" name required by the main branch ruleset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: use nested PriceScale in the volume overlay skill recipe

The price/volume skill recipe described the PriceScale pane index bug and
configured the overlay scale through series refs and a ready loop. Now that
PriceScale targets its own pane and waits for its parent series, nest
PriceScale in the series instead. Keep a version note with a small series API
fallback for 2.6.1, which is still inside the skill compatibility range.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: report markdown line numbers in link check errors

markdown-it sets `map` only on block tokens, so every link (an inline child
token) was reported on line 0. Take the line from the parent block and add the
line breaks before the link, so links later in a multi-line paragraph get
their exact line.

Co-Authored-By: Claude Opu... (continued)

332 of 336 branches covered (98.81%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

609 of 609 relevant lines covered (100.0%)

27.0 hits per line