• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

thumbor / thumbor / 42533255915
93%

Build:
DEFAULT BRANCH: master
Ran 08 Nov 2026 11:05PM UTC
Jobs 5
Files 104
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Nov 2026 11:03PM UTC coverage: 91.997% (+0.2%) from 91.829%
42533255915

push

github

marcelometal
fix(gif): pass integer dimensions to gifsicle

The transformer computes target sizes as floats (float(width) for the
requested side, proportional math for the other), and the gifsicle engine
interpolated them straight into the command line, producing arguments like
"--resize 70x70.0". Gifsicle up to 1.97 printed "invalid dimensions" to
stderr but exited 0 and went on with whatever it had parsed before the first
dot: a float width kept only the width, with the height left to its
proportional default. thumbor never noticed because it only logs stderr on a
non-zero exit and the crop that precedes the resize had already set the
aspect ratio. Gifsicle 1.98 parses arguments strictly and rejects them, so
every animated GIF request through USE_GIFSICLE_ENGINE that ends in a
float-valued size fails with a 500 ("cannot identify image file"). The
engine now casts width and height to int before building the arguments,
which is what the Pillow engine already does, and does the same for the crop
coordinates.

The values are whole numbers by the time they reach the engine, so the cast
does not change the requested size. With older gifsicle versions the output
stays identical except where the proportional height differed from the
requested one by a pixel: 50x70 from a 100x100 source came out 50x69 and now
comes out 50x70, matching the Pillow engine. The crop cast is defensive: the
requests I traced hand the engine whole-number crop coordinates already. The
tests exercise resize and crop with float inputs through the real gifsicle
binary and a handler request with the gifsicle engine on, and fail on 1.98
without the cast.

2 of 2 new or added lines in 1 file covered. (100.0%)

4483 of 4873 relevant lines covered (92.0%)

4.6 hits per line

Jobs
ID Job ID Ran Files Coverage
1 run-3.14 - 42533255915.1 08 Nov 2026 11:05PM UTC 104
92.0
GitHub Action Run
2 run-3.13 - 42533255915.2 08 Nov 2026 11:06PM UTC 104
92.0
GitHub Action Run
3 run-3.15 - 42533255915.3 08 Nov 2026 11:05PM UTC 104
92.0
GitHub Action Run
4 run-3.11 - 42533255915.4 08 Nov 2026 11:06PM UTC 104
92.0
GitHub Action Run
5 run-3.12 - 42533255915.5 08 Nov 2026 11:06PM UTC 104
92.0
GitHub Action Run
Source Files on build 42533255915
  • Tree
  • List 104
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42533255915
  • 8031ab5b on github
  • Prev Build on master (#42532907813)
  • Next Build on master (#42534703585)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc