• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ProjectOpenSea / seadrop / 42530527195
81%

Build:
DEFAULT BRANCH: main
Ran 08 Nov 2026 10:31PM UTC
Jobs 1
Files 31
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Nov 2026 10:29PM UTC coverage: 81.428% (+0.7%) from 80.758%
42530527195

push

github

web-flow
Cancel a pending owner on renounce and bind clone salts to the caller (#217)

## Motivation

An audit of this round's `main` changes turned up two low-severity
problems worth fixing before the new clone factory ships. Both predate
this round.

`renounceOwnership`, from utility-contracts' `TwoStepOwnable`, leaves
`potentialOwner` set. If an owner nominates someone with
`transferOwnership` and then renounces, the nominee can still call
`acceptOwnership` and take back a contract that looks renounced. On
`ERC721SeaDropLockable` the nominee could then call `lockPermanently`,
even though ERC-8451 consumers read `owner() == address(0)` as "nobody
can change the lock".

`ERC721SeaDropCloneFactory.createClone` derived the clone salt as
`keccak256(abi.encodePacked(salt, blockhash(block.number)))`. The
blockhash of the current block is always 0, so a clone's address depends
only on the salt the caller passes. Anyone who copies the salt from a
pending `createClone` transaction gets a clone at that address, owned by
them, and the original call reverts. os2-core picks random salts and
learns clone addresses from ingestion, so the impact is griefing. #196
left this for an owner decision because fixing it moves clone addresses,
but a new factory moves them anyway.

## Solution

- `ERC721ContractMetadata`, `ERC721ContractMetadataCloneable` and
`ERC721ContractMetadataUpgradeable` override `renounceOwnership` to call
`cancelOwnershipTransfer()` before renouncing. It emits
`PotentialOwnerUpdated(address(0))`, and other callers still get
`OnlyOwner`. `ERC721SeaDropLockable` still checks for a temporary lock
after the renounce.
- `createClone` now uses `keccak256(abi.encode(msg.sender, salt))`.
Nothing in os2-core or os2-web predicts clone addresses. os2-core only
encodes the `createClone` call, in
`CreatorStudioDeployContractHelper.kt`.

## Deployment impact

- Deployed contracts don't change. Lockables that partners deployed from
the deploy page, which pins 0d3fbf3, keep... (continued)

195 of 268 branches covered (72.76%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 4 files covered. (100.0%)

1208 of 1455 relevant lines covered (83.02%)

2305.63 hits per line

Jobs
ID Job ID Ran Files Coverage
1 foundry - 42530527195.1 08 Nov 2026 10:31PM UTC 31
81.43
GitHub Action Run
Source Files on build 42530527195
  • Tree
  • List 31
  • Changed 6
  • Source Changed 5
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #42530527195
  • 9e73df81 on github
  • Prev Build on main (#42525785241)
  • Next Build on main (#42572350109)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc