FlexMeasures / flexmeasures-client / 42501082960

95%

Build Type

push

github

Committed by web-flow

Commit Message

feat(S2): #188 finished, reconciled onto main (1 of 2) (#278)

* fix(TUNES): record a leakage behaviour instead of refusing it

FillRateBasedControlTUNES.send_leakage_behaviour read its fill-level scale from
self._fill_level_scalefill_level_scale, an attribute name pasted in twice, which
has been there since #158. The AttributeError that raised was caught by the
handler's broad except as if the post had failed, so every FRBC.LeakageBehaviour
was answered with PERMANENT_ERROR and none was ever recorded.

mypy could not see it: the type-check task only looks at files that contain
`from typing import`, and the FRBC base class is not one of them, so the
attribute lookup went to Any. The next commit widens that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcpawsJs74cSwFLXkz7ZwW
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* chore(types): check every source file, including untyped function bodies

The type-check task fed mypy only the files that contain `from typing import`,
which were seven of eighteen, and left out frbc_simple.py, both control-type
__init__.py files and the example scripts. With --follow-imports skip, anything
those files defined then looked like Any to the files that were checked, which
is how the previous commit's misspelt attribute went unnoticed since #158.

It now checks all of src, and with --check-untyped-defs, so the bodies of
functions without annotations are checked too. What that surfaced, besides the
attribute fixed in the previous commit:

- get_access_token stored a token whose type could be None and then used it as a
  header value; it now returns the token, so the caller holds a str.
- get_access_token and get_versions indexed a response typed as a dict or a list;
  each now says so plainly when the server answers with something other than an
  object, instead of failing on the lookup.
- The S2 translations annotated their resolution as a string while frbc_... (continued)

Coverage Stats

816 of 822 new or added lines in 15 files covered. (99.27%)

1 existing line in 1 file now uncovered.

2909 of 3064 relevant lines covered (94.94%)

4.64 hits per line