Giorgi / DuckDB.NET / 42500417460

94%

push

github

Match seven native declarations to duckdb.h (#390)

* Match seven native declarations to duckdb.h

Seven LibraryImport declarations used a type of a different width from
the C prototype:

- duckdb_append_varchar_length, duckdb_append_blob: idx_t length was int
- duckdb_append_default_to_chunk: idx_t column was int
- duckdb_config_count: size_t return was int
- duckdb_get_config_flag: size_t index was int
- duckdb_extract_statements: idx_t return was int
- duckdb_data_chunk_set_size: void return was long

They work by chance on x64 and arm64, where a 32-bit argument usually
arrives zero-extended and an unread return value does no harm, but the
calling conventions do not promise it. On WebAssembly a call through a
mismatched signature traps, which is how they were found.

idx_t parameters and returns are now ulong, size_t ones nuint, and
duckdb_data_chunk_set_size returns void. The callers are adjusted.

NativeSignatureTests compares every LibraryImport with the duckdb.h
downloaded next to the native library: the integer, size_t and floating
point widths of each parameter and return type, void returns and the
parameter counts. On the previous declarations it reports exactly these
seven. NativeBindingWidthTests calls each fixed function directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUiK1qo6GjwvWsj2SfpLQW

* Leave the header signature test out for now

NativeSignatureTests is set aside for the time being; the direct tests
in NativeBindingWidthTests stay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUiK1qo6GjwvWsj2SfpLQW

* Remove NativeBindingWidthTests

The existing tests already run the fixed functions through DuckDB.NET's
own code paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUiK1qo6GjwvWsj2SfpLQW

* Shorten the release note for the declaration fixes

Co-A... (continued)

2851 of 3093 branches covered (92.18%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 3 files covered. (100.0%)

4480 of 4736 relevant lines covered (94.59%)

1022373.54 hits per line