microlinkhq / metascraper / 42498130484

95%

push

github

fix(metascraper): log rule values without a string form (#890)

* fix(metascraper): log rule values without a string form

The per-rule debug line interpolated the value into a template literal
outside the try block. A null-prototype object (what an `evaluate` rule
such as `window.location` returns) has no toPrimitive, so it threw
"Cannot convert object to primitive value" and rejected the whole
extraction. Symbols and null-prototype functions threw the same way.
The message is built even when debug is off.

The line now prints primitive values and the type of anything else, so
it never throws and never serializes a large value on every extraction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(metascraper): lock the debug form of each printable rule value

The suite only checked that unusual values came back, so logging a string, number, boolean, bigint, or null as its type still passed. Assert the logged text for each, and drop undefined, which never reaches the logger.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

867 of 934 branches covered (92.83%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

3156 of 3300 relevant lines covered (95.64%)

39.07 hits per line