websockets / ws / 42489080506

100%

push

github

[perf] Do not retain the read buffer via the close reason (#2354)

The close reason is emitted with the `'conclude'` event as a view into
the buffer the stream delivered, and is kept as
`websocket._closeMessage`. Consequently, a closed `WebSocket` that is
still referenced keeps that whole buffer, commonly 64 KiB, alive.

Copy the reason when it is assigned to `websocket._closeMessage`. A
pooled copy would pin the `Buffer` pool the same way, since
`Buffer.poolSize` is 64 KiB on recent Node.js versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1152 of 1158 branches covered (99.48%)

4 of 4 new or added lines in 1 file covered. (100.0%)

1681 of 1682 relevant lines covered (99.94%)

29142.72 hits per line