CyclopsMC / EvilCraft / 42452204050

41%

master-26-lts: 41%

Pull #1301

github

Fix flaky environmental accumulator game test

The test could produce a rain container instead of a clear one when
an earlier test left the world raining. Weather type checks use the
rain level, which keeps fading for up to 80 ticks after the rain flag
is cleared, so the accumulator still matched the rain recipe.

The test now waits for clear weather before inserting the container.

Clear weather activation now also unconditionally clears the rain
flag. Before, clearing a thunderstorm only stopped the thunder, as the
rain check still saw the fading thunder level. This also affected
clear weather containers thrown during thunderstorms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeSuG8Kqrwqjrrqtnp6nMf

1338 of 5520 branches covered (24.24%)

Branch coverage included in aggregate %.

7600 of 16072 relevant lines covered (47.29%)

2.28 hits per line