ponder-lab / Hybridize-Functions-Refactoring / #4138

90%

push

github

Refuse a constant name an unnamed sibling may also get (#1265)

* Refuse a constant name an unnamed sibling may also get

Keras names an unnamed layer after its class in snake case, `dense` or
`dense_<n>`, counting only the names it makes, so `Dense(4)` beside
`Dense(4, name="dense")` are both named `dense`, and their variables
collide. An unnamed sublayer was taken never to collide. A constant name
that is the name Keras makes for an unnamed sublayer's class, with or
without a `_<n>` suffix, now refuses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Name an unnamed library layer after each of its bases too

The engine models a Keras alias such as `Convolution2D` as a subclass of
the class it names, `Conv2D`, and Keras names the layer after that class,
`conv2d`. An unnamed library layer's generated names now come from its
class and from each of its bases below `Layer`; a program class's come
from its own name only. The alias's own construction isn't modeled yet
(wala/ML#1236), so the new row is pinned as a missed refusal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Name the separable convolution aliases in the alias TODO

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Tell a program layer class by its declaring script

The engine models a library layer such as `Dense` as a Python class too, so a library class's bases were never walked. Pin a constant name equal to a counted generated one, and a program subclass named after itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

33 of 33 new or added lines in 2 files covered. (100.0%)

6808 of 7575 relevant lines covered (89.87%)

0.9 hits per line