cameri / nostream / 42373933224

78%

push

github

fix(payments): accept LNbits 1.x callback bodies (#1067)

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
## Problem

LNbits 1.x sends the payment object as a JSON string inside the webhook
body, effectively double-encoding it. The route used Express's default
strict JSON parser, which rejected the top-level string with `400`. Even
with an object body, the strict Zod schema rejected LNbits' extra
payment fields.

As a result, paid invoices were only confirmed by the maintenance poll
up to a minute later, while the invoice page still showed “waiting for
payment”.

## Fix

- `/callbacks/lnbits` now uses `json({ strict: false })`, accepting both
object and JSON-string bodies.
- The controller parses string bodies and returns `400 Malformed body`
for invalid JSON.
- The body schema is no longer strict; it validates `payment_hash` and
strips LNbits' extra fields.
- HMAC verification and invoice lookup from LNbits remain unchanged.

## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
Closes - #1066 
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Non-functional change (docs, style, minor refactor)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking chang... (continued)

4890 of 6906 branches covered (70.81%)

Branch coverage included in aggregate %.

18 of 20 new or added lines in 3 files covered. (90.0%)

10664 of 13143 relevant lines covered (81.14%)

701.32 hits per line