datatug / datatug-cli / 42372393923

100%

Build Type

push

github

Committed by web-flow

Commit Message

fix(dbcopy): refuse to copy labelled columns of a project source (#590)

Builds on datatug/datatug-cli#589, which has landed on `main`; this PR targets `main` and has `main` merged in.

Source commits:

- 37c574e11116 fix(db copy, db export): refuse to copy labelled columns of a project source
  A datatug:// --from now has its Meaning Graph sensitivity labels checked
  before anything is written: a selected table with a protected effective
  column (owner label, pending proposal or read-time suggestion) refuses
  the copy or export with exit 5 and FIELD_PROTECTED, for every caller.
  No copy engine masks, so refusing is the only safe behaviour. Unlabelled
  tables (--include/--exclude) copy as before; non-project sources are
  unchanged. Reuses the label machinery of the project-read guard
  (loadLabels, EffectiveObject, projectRead.describe).
  Spec: REQ:project-source-labels in spec/features/cli/db/copy.
- d9472a734b94 fix(db copy, db export): check labels in the copy's schema, after usage checks
  Review round 1 (Reviewed-Head 37c574e1):
  - the label check opened the source with the default PostgreSQL schema, so
  --from-schema let a labelled table through; it now opens the source as
  the copy does (openCopySource with --from-schema);
  - usage errors (?records-format, non-faithful --json/--dry-run, sqlscript
  from a non-SQLite source, same file, existing script) are reported with
  their exit code before the label check opens the source;
  - a source whose tables cannot be listed now refuses even with no label
  stored for it: a copy writes every table;
  - the single-catalog lookup is documented as shared with query run
  --db datatug:// (alias catalogs are a follow-up);
  - tests: db copy --json refusal, datatug:///<db>, --filter-config,
  usage-before-labels ordering, schema passed to the open.
- 0331ac4be420 Merge remote-tracking branch 'origin/main' into copy-export-labels
- 4680689d58b9 fix(dbcopy): copy label guard follows the final #589... (continued)

Coverage Stats

85 of 85 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

99026 of 99028 relevant lines covered (100.0%)

1.01 hits per line