cameri / nats-server / 42339657740
78%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.375% (-4.2%) from 82.599%
42339657740

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

67742 of 86433 relevant lines covered (78.38%)

276642.92 hits per line

Coverage Regressions

Lines Coverage ∆ File
2077
33.82
-54.79% src/github.com/nats-io/nats-server/server/mqtt.go
597
63.54
-14.2% src/github.com/nats-io/nats-server/server/opts.go
214
44.85
-45.92% src/github.com/nats-io/nats-server/server/msgtrace.go
135
59.01
-8.45% src/github.com/nats-io/nats-server/server/reload.go
129
89.94
-2.97% src/github.com/nats-io/nats-server/server/client.go
112
0.0
-52.83% src/github.com/nats-io/nats-server/server/proto.go
98
78.09
-2.04% src/github.com/nats-io/nats-server/server/raft.go
62
82.77
-8.08% src/github.com/nats-io/nats-server/server/parser.go
61
81.94
-2.84% src/github.com/nats-io/nats-server/server/route.go
41
85.57
-0.6% src/github.com/nats-io/nats-server/server/stream.go
39
83.0
-0.12% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
31
88.16
-1.13% src/github.com/nats-io/nats-server/server/server.go
26
73.54
-0.26% src/github.com/nats-io/nats-server/server/jetstream_api.go
23
78.02
-0.14% src/github.com/nats-io/nats-server/server/filestore.go
16
86.06
-1.34% src/github.com/nats-io/nats-server/server/auth.go
16
87.45
-0.09% src/github.com/nats-io/nats-server/server/consumer.go
15
86.03
-0.19% src/github.com/nats-io/nats-server/server/accounts.go
15
84.72
-0.46% src/github.com/nats-io/nats-server/server/events.go
12
10.38
-11.32% src/github.com/nats-io/nats-server/server/signal.go
10
89.15
-0.42% src/github.com/nats-io/nats-server/server/leafnode.go
9
72.96
-5.66% src/github.com/nats-io/nats-server/server/log.go
8
93.19
-0.24% src/github.com/nats-io/nats-server/server/gateway.go
8
74.42
-4.65% src/github.com/nats-io/nats-server/server/jwt.go
5
91.9
-0.72% src/github.com/nats-io/nats-server/server/jetstream_batching.go
5
65.51
-0.47% src/github.com/nats-io/nats-server/server/websocket.go
4
86.48
-0.11% src/github.com/nats-io/nats-server/server/monitor.go
4
90.11
-0.38% src/github.com/nats-io/nats-server/server/sublist.go
2
84.49
-0.1% src/github.com/nats-io/nats-server/server/jetstream.go
2
98.44
-1.56% src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2
85.45
-0.94% src/github.com/nats-io/nats-server/server/util.go
1
76.56
-1.56% src/github.com/nats-io/nats-server/server/errors.go
Jobs
ID Job ID Ran Files Coverage
1 42339657740.1 66
78.38
GitHub Action Run
Source Files on build 42339657740