visgl / deck.gl / 42338409747

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(geo-layers): clip MVTLayer sub layers to the tile under GlobeView (#10727)

* fix(geo-layers): clip MVTLayer sub layers to the tile under GlobeView

`renderSubLayers` applied `ClipExtension` only inside the branch that sets up the
tile-local CARTESIAN coordinate system, and that branch is skipped when the viewport
has a `resolution` (GlobeView). Sub layer data is then WGS84 with nothing constraining
a feature to its tile, so a feature the tiler wrote into every tile it touches is drawn
once per tile.

Clip on the WGS84 path too, against the tile's own lng/lat bbox.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(geo-layers): make the MVTLayer tile clip authoritative and explicit

Follow-up to the tile clip, addressing code review findings.

- Widen the `renderSubLayers` parameter type with `ClipExtensionProps` so
  assigning `clipBounds` type checks
- Set `clipBounds` explicitly on both coordinate paths instead of relying
  on the `ClipExtension` default on the Mercator path
- Warn and override when a user supplies `clipBounds`, which would
  otherwise break the per-tile clip
- Reuse a user-supplied `ClipExtension` rather than appending a second
  one, which injected the same shader declarations twice
- Unify the two remaining `viewport.resolution` checks on `_isWGS84()`
- Document the half-open clip boundary and the non-geographic `bbox`
  fallthrough
- Cover the clip at zoom 2 so per-tile bounds are asserted, and add a
  test for the user clip prop override
- Document sub layer clipping in the MVTLayer API reference

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs(geo-layers): trim MVTLayer clipping docs to a remarks bullet

Drop the sub layer clipping explanation. Users only need to know that
`clipBounds` is ignored and to reach for `extent` instead.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(geo-layers): don't warn about ClipExtension's default clipBounds in MVTLayer

ClipExtension adds its defaul... (continued)

Coverage Stats

10888 of 13334 branches covered (81.66%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

17484 of 20037 relevant lines covered (87.26%)

31625.12 hits per line